ISSUE SUMMARY:
When viewing site as guest the menu type Community->All Photos directs users to "My Photos" instead of "All Photos". Also shows guests the "Create Photo Album" link. When a user is logged in the menu type Community->All Photos works properly.


STEPS TO REPLICATE:
1 View JomSocial Demo: demo.jomsocial.com
2 DO NOT log in.
3 As a guest click "Photos"
4
5
RESULT "My Photos" is shown
EXPECTED RESULT "All Photos" or "Photos" should be shown
BROWSER All

Hi David,

Thank you for reporting, this is a valid bug.

cheers!

Hi,

this is the fix if you use 4.1.1
- open this file components/com_community/views/photos/view.html.php
- find this code :

if($task=='myphotos'){

if($task=='myphotos' && $my->id){

I made the change that you suggested and the problem is not fixed.

FYI..... all lines in that file that contain "if($task=='myphotos'){" relate to albums.

Actually, I was able to fix it in the template file.

Towards the top of components/com_community/templates/jomsocial/layouts/album/list.php
Change:

    if($type == PHOTOS_GROUP_TYPE){
        $title = JText::_('COM_COMMUNITY_GROUP_PHOTOS');
    }elseif($isOwner){
        $title = JText::_('COM_COMMUNITY_PHOTOS_MY_PHOTOS_TITLE');
    }else{
        $title = JText::_('COM_COMMUNITY_PHOTOS');
    }

    if($type == PHOTOS_GROUP_TYPE){
        $title = JText::_('COM_COMMUNITY_GROUP_PHOTOS');
    }elseif($isOwner && $my->id){
        $title = JText::_('COM_COMMUNITY_PHOTOS_MY_PHOTOS_TITLE');
    }else{
        $title = JText::_('COM_COMMUNITY_PHOTOS');
    }

The issue is caused by the following statement in components/com_community/views/photos/view.html.php:
$isOwner = ($my->id == $userId) ? true : false;

The problem is $my->id for guests is 0 AND $userId for guests is also 0. Therefore; $isOwner will always be set to true (1) for guests.

The core fix for this is as follows:

In components/com_community/views/photos/view.html.php
Change:

$isOwner = ($my->id == $userId) ? true : false;

if ($userId) {
     $isOwner = ($my->id == $userId) ? true : false;
} else {
     $isOwner = 0;					
}

Thank you for your input.. I will report this to our developer..