Notices for undefined variables are fixed using @ before variable names.
Notice: Undefined property: stdClass::$id in modules\mod_ijoomla_adagency_zone\helper.php on line 1655
Notice: Undefined property: stdClass::$type in modules\mod_ijoomla_adagency_zone\helper.php on line 1777
Redirection problem:
Search by: AD_FAILEDAPPROVE, find $link="..." without JRoute::_ wrapper.
\components\com_adagency\controllers\adagencyReports.php:42, :80
adAgencyCpanel.php:37
...[about 10-12 files]...
Example:
$link="index.php?option=com_adagency".$Itemid;
Programmer forgot to use JRoute on link. Also JRoute second parameter should be false to not escape link, used later for redirections.
=> $link=JRoute::_("index.php?option=com_adagency".$Itemid, false);
Solution is regular expression search and replace through components\com_adagency\controllers\:
Find: ^(\s*)\$link(\s*)=(\s*)("index[^;]+);
Replace with: $1$link$2=$3JRoute::_($4, false);
Next problem does not concerns language at all. Infinite redirections are caused by adagencyCPanel.php.
It redirects unapproved advertisers to:
$item_id = $this->model2->getItemid('adagencyadvertiser');
:37 => $link=JRoute::_("index.php?option=com_adagency".$Itemid, false);
:50 => } elseif($adv_id[1]!='Y'){
$this->setRedirect($link, JText::_('AD_FAILEDAPPROVE'), 'notice');
}
Here the issue goes:
docs.joomla.org/Potential_backward_compa...Joomla_Platform_12.2
>> JDatabase::getEscaped() has been removed. Use JDatabase::escape() instead
Now look at com_adagency\models\adagencyconfig.php
function getItemid($controller){var_dump($controller);
$db = JFactory::getDBO();
$controller = $db->getEscaped($controller); // <<< ERROR, null returned
$sql = "SELECT id FROM `#__menu`
WHERE `menutype` = 'adagency'
AND `link` LIKE '%index.php?option=com_adagency&view={$controller}%' ";
//echo "** " . $sql . " **";die();
$db->setQuery($sql);
$res = (int)$db->loadResult();var_dump([$controller, $sql, $res]);
return ($res == 0) ? JRequest::getInt('Itemid', '0', 'get') : $res;
}
$controller = $db->getEscaped($controller); => null
SQL query LIKE finds first matching "&view=" menu item, in our case, control panel itself. Thus we got infinite redirection.
Solution: replace method name "getEscaped" with "escape".
Please, fix the above mentioned at your side, including notices silencing so that updates would not ruin our project.
Git diff with fixes is attached to post.
Attachment diff.txt not found
