Hi Albertus,
I checked the accounts and in fact found that all users have enabled those email types. After debugging the controller, the following line seems to be the issue:
CNotificationLibrary::add( 'group_join_request', $my->id, $group->ownerid, JText::sprintf('COM_COMMUNITY_GROUP_JOIN_REQUEST_SUBJECT'), '', 'groups.joinrequest', $params );
Several issues are in that line that prevent a correct functioning. The correct line must be
CNotificationLibrary::add( 'groups_member_join', $my->id, $group->ownerid, JText::sprintf('COM_COMMUNITY_GROUP_JOIN_REQUEST_SUBJECT'), '', 'groups.memberjoin', $params );
Please notice that strings that are different. The correct notification property is
whereas the correct template name is
- then correct profile settings and email template are chosen.
Please consider this in next JS version (the issue also appears in groups.trigger.php file - but I cannot see when this code is being executed).
An even better fix is attached which sends the email to all admins of such a group not only it's owner.
Regards
Ralph
Update Seems like I cannot attach the diff file, So I paste it here
3235a3236,3238
> $user = $my;
> $approved = false;
>
3239,3240c3242,3251
<
< CNotificationLibrary::add( 'group_join_request', $my->id, $group->ownerid, JText::sprintf('COM_COMMUNITY_GROUP_JOIN_REQUEST_SUBJECT'), '', 'groups.joinrequest', $params );
---
> $params->set('group' , $group->name );
> $params->set('group_url' , 'index.php?option=com_community&view=groups&task=viewgroup&groupid='.$group->id );
> $params->set('user' , $user->getDisplayName() );
> $params->set('user_url' , 'index.php?option=com_community&view=profile&userid='.$user->id );
> $params->set('approved' , $member->approved );
> $admins = $groupModel->getAdmins($groupId, null);
> $subject = JText::sprintf( 'COM_COMMUNITY_NEW_MEMBER_REQUESTED_TO_JOIN_GROUP_EMAIL_SUBJECT' , '{user}' , '{group}' );
> foreach ($admins AS $admin) {
> CNotificationLibrary::add( 'groups_member_join', $my->id, $admin->id, $subject, '', 'groups.memberjoin', $params );
> }
